Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the documentation to import a subset of k8s logs #1276

Conversation

BeElectronicSakshi
Copy link

Updated the doc to import a subset of k8s logs

Details:
Updated documentation for Log collection for a subset of pods or containers

File modified:
charts/opentelemetry-collector/README.md

Copy link

linux-foundation-easycla bot commented Jul 24, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@BeElectronicSakshi
Copy link
Author

@TylerHelmuth, Can you review & approve the PR: #1276

Copy link

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added Stale and removed Stale labels Aug 10, 2024
@kayhern kayhern force-pushed the documentation/879-to-import-a-subset-of-k8s-logs branch from 5e78f2f to 9a20e23 Compare August 21, 2024 13:07
Copy link

github-actions bot commented Sep 6, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 6, 2024
@kayhern kayhern force-pushed the documentation/879-to-import-a-subset-of-k8s-logs branch from 96cd059 to 945ace9 Compare September 10, 2024 20:24
@github-actions github-actions bot removed the Stale label Sep 11, 2024
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs' update looks good. However, I'm not sure if the chart's version needs to be updated.

@@ -1,6 +1,6 @@
apiVersion: v2
name: opentelemetry-collector
version: 0.104.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to upgrade the chart's version for this documentation update.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrsMark any change within the chart dir require a version update.

@BeElectronicSakshi please update the version to be 0.105.2 and then run make generate-examples CHARTS=opentelemetry-collector

Signed-off-by: Mishra, Sakshi <[email protected]>
@kayhern kayhern requested a review from a team as a code owner September 25, 2024 13:31
@@ -1,6 +1,6 @@
apiVersion: v2
name: opentelemetry-collector
version: 0.104.0
version: 0.105.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will now need to be 0.106.2 since the version has already been bumped up: https://github.com/open-telemetry/opentelemetry-helm-charts/blob/main/charts/opentelemetry-collector/Chart.yaml#L3

Also, please run make generate-examples CHARTS=opentelemetry-collector to update the examples' versions.

Copy link

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 10, 2024
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants