-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the documentation to import a subset of k8s logs #1276
Update the documentation to import a subset of k8s logs #1276
Conversation
@TylerHelmuth, Can you review & approve the PR: #1276 |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
5e78f2f
to
9a20e23
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Signed-off-by: Mishra, Sakshi <[email protected]>
Signed-off-by: Mishra, Sakshi <[email protected]>
Signed-off-by: Mishra, Sakshi <[email protected]>
Signed-off-by: Mishra, Sakshi <[email protected]>
Signed-off-by: Mishra, Sakshi <[email protected]>
96cd059
to
945ace9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs' update looks good. However, I'm not sure if the chart's version needs to be updated.
@@ -1,6 +1,6 @@ | |||
apiVersion: v2 | |||
name: opentelemetry-collector | |||
version: 0.104.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to upgrade the chart's version for this documentation update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChrsMark any change within the chart dir require a version update.
@BeElectronicSakshi please update the version to be 0.105.2
and then run make generate-examples CHARTS=opentelemetry-collector
Signed-off-by: Mishra, Sakshi <[email protected]>
@@ -1,6 +1,6 @@ | |||
apiVersion: v2 | |||
name: opentelemetry-collector | |||
version: 0.104.0 | |||
version: 0.105.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will now need to be 0.106.2
since the version has already been bumped up: https://github.com/open-telemetry/opentelemetry-helm-charts/blob/main/charts/opentelemetry-collector/Chart.yaml#L3
Also, please run make generate-examples CHARTS=opentelemetry-collector
to update the examples' versions.
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Updated the doc to import a subset of k8s logs
Details:
Updated documentation for Log collection for a subset of pods or containers
File modified:
charts/opentelemetry-collector/README.md