Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint issue for golangci-lint 1.62.0 #6322

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

dmathieu
Copy link
Member

This fixes the sole linting issue required to allow the upgrade to golangci-lint 1.62.0 in #6320.

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Nov 12, 2024
@dmathieu dmathieu marked this pull request as ready for review November 12, 2024 10:00
@dmathieu dmathieu requested review from pellared and a team as code owners November 12, 2024 10:00
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.7%. Comparing base (717e1db) to head (6a2bc78).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6322   +/-   ##
=====================================
  Coverage   66.7%   66.7%           
=====================================
  Files        193     193           
  Lines      15565   15565           
=====================================
  Hits       10391   10391           
  Misses      4883    4883           
  Partials     291     291           
Files with missing lines Coverage Δ
bridges/otelzap/encoder.go 100.0% <100.0%> (ø)

bridges/otelzap/encoder.go Outdated Show resolved Hide resolved
@pellared
Copy link
Member

Merging as trvial

@pellared pellared merged commit 72585fd into open-telemetry:main Nov 13, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants