Fix exporter/user_events build and installation as external component for opentelemetry-cpp #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
… opentelemetry-cpp build.
spoax
force-pushed
the
fix-user_events-otel_add_component
branch
from
9a27944 to
1ee4f43
Compare
ThomsonTan
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the logic in
exporters/user_events/CMakeLists.txtto ensure that theproject(opentelemetry-user_events-exporter)declaration only occurs when the CMake file is the main project. This change helps prevent issues when including this exporter as a subproject in opentelemetry-cpp build.The project() command changes the PROJECT_SOURCE_DIR variable, which is used for the scope of the external components list variable in opentelemetry-cpp. This causes the user_events to be registered in the wrong list, and installation fails to install lib and include files.
Build system improvements:
project(opentelemetry-user_events-exporter)declaration inside the main project check to avoid redefining the project when included as a subproject.