Skip to content

chore(lint): add eslint header and baseline rules #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
overbalance merged 8 commits into from
Dec 18, 2025
Merged

chore(lint): add eslint header and baseline rules #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8255606
chore(lint): add baseline
overbalance Dec 12, 2025
55463a8
chore(lint): add license header rule
overbalance Dec 12, 2025
af31885
use short form rule
overbalance Dec 14, 2025
2d20a39
use new rules
overbalance Dec 14, 2025
d22e3b3
Merge remote-tracking branch 'upstream/main' into overbalance/add-esl…
overbalance Dec 15, 2025
0f395e2
feat(eslint): allow extended copyright headers in license pattern
overbalance Dec 15, 2025
f8d87f8
Merge remote-tracking branch 'upstream/main' into overbalance/add-esl…
overbalance Dec 16, 2025
1e6161f
Merge remote-tracking branch 'upstream/main' into overbalance/add-esl…
overbalance Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ jobs:

- run: npm ci

- run: npx biome ci
- run: npm run lint:ci
39 changes: 39 additions & 0 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
import baselinePlugin from 'eslint-plugin-baseline-js';
import yalhPlugin from 'eslint-plugin-yet-another-license-header';
import tseslint from 'typescript-eslint';

const defaultLicense = `
/*
* Copyright The OpenTelemetry Authors
* SPDX-License-Identifier: Apache-2.0
*/
`;

const licensePattern =
/^\/\*\n \* Copyright The OpenTelemetry Authors(?:, [^\n]+)*\n(?: \* Copyright [^\n]+\n)*(?: \*\n)? \* SPDX-License-Identifier: Apache-2\.0\n \*\/$/;

export default [
{
files: ['packages/*/src/**/*.{js,ts,mjs}'],
languageOptions: {
parser: tseslint.parser,
},
plugins: {
'baseline-js': baselinePlugin,
Copy link

@trentm trentm Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this effectively duplicating biome linting? I understand they aren't identical.

Copy link
Contributor Author

@overbalance overbalance Dec 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's not. This is only running the baseline plugin and the header plugin which are not available in the biome plugin format. Both features are essential so while running biome and eslint is not ideal, it's still a major speed up from running eslint recommended rules on its own.

'yet-another-license-header': yalhPlugin,
},
rules: {
...baselinePlugin.configs['recommended-ts']({
available: 'widely',
level: 'error',
}).rules,
'yet-another-license-header/header': [
'error',
{
header: defaultLicense,
allowedHeaderPatterns: [licensePattern],
},
],
},
},
];
Loading