Repository navigation
Use n2k v1.8.1 and enforce CGO-disabled releases - #34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade Beacon to the released n2k v1.8.1 so macOS binaries build with
CGO_ENABLED=0, resolving the serial-enumerator failure in the previous release build. Bump Beacon'sVERSIONfrom 1.3.4 to 1.3.5.Keep CGO disabled in GoReleaser and Docker, and check each compiled binary's recorded build settings before it can be packaged. The shared guard rejects CGO-enabled binaries and missing build metadata. CI now builds and checks amd64 and arm64 binaries on Linux, macOS, and Windows. Document the distribution requirement in README.md and AGENTS.md; CGO remains available for race-detector testing.
Validation passed:
CGO_ENABLED=0, even withCGO_ENABLED=1in the parent environment./app/beaconbinaries, and verified Beacon 1.3.5, n2k v1.8.1, the expected architecture, andCGO_ENABLED=0.CGO_ENABLED=0 go test ./... -timeout 300s,go vet ./...,just lint,just secure,just release-check, actionlint, GoReleaser configuration validation, and shell syntax checks.