Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Other issue]: Ambiguous return values for some cases #3

Open
1 task done
Vortex-TH opened this issue Aug 19, 2024 · 0 comments
Open
1 task done

[Other issue]: Ambiguous return values for some cases #3

Vortex-TH opened this issue Aug 19, 2024 · 0 comments
Assignees

Comments

@Vortex-TH
Copy link

Before proceeding, is there an existing issue or discussion for this?

Description

It should be clarified what is expected to be returned in the following cases:

    def current_floor(self) -> Optional[str]:
        ''' Returns the current floor of this lift, or None the query failed'''

What should be returned if the lift is moving between two floors? My assumption is to return the last floor it was at until it has reached the new floor.


    def destination_floor(self) -> Optional[str]:
        ''' Returns the destination floor of this lift, or None the query
            failed'''

What should be returned if the lift is idle at some floor? My assumption is to return the current floor.

@Vortex-TH Vortex-TH changed the title [Other issue]: [Other issue]: Ambiguous return values for some cases Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants