Addition/Deletion/Updation of common-mrw repo, Removal of hard code default #51
Open
GiridhariKrishnan wants to merge 1 commit intoopen-power:masterfrom
GiridhariKrishnan:master
Open
Addition/Deletion/Updation of common-mrw repo, Removal of hard code default #51GiridhariKrishnan wants to merge 1 commit intoopen-power:masterfrom GiridhariKrishnan:master
GiridhariKrishnan wants to merge 1 commit intoopen-power:masterfrom
GiridhariKrishnan:master
Conversation
and user choice for Default Repo. Alert for users while overlaying over the base repo.
| try { | ||
| Properties p = new Properties(); | ||
| File f = new File(ServerWizard2.PROPERTIES_FILE); | ||
| Display display = new Display(); |
Collaborator
There was a problem hiding this comment.
As discussed, these directory dialogs are not needed anymore. What purpose were they achieving?
| try { | ||
| Properties p = new Properties(); | ||
| File f = new File(ServerWizard2.PROPERTIES_FILE); | ||
| DirectoryDialog fdlg = new DirectoryDialog(shell, SWT.OPEN); |
Collaborator
There was a problem hiding this comment.
Please revert this change
santoshpuranik
requested changes
Sep 13, 2019
Collaborator
santoshpuranik
left a comment
santoshpuranik
left a comment
There was a problem hiding this comment.
Please clean this PR up. There seem to be several unnecessary changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
common-mrw and user choice for Default Repo. Alerts for users while overlaying over the base repo.