Skip to content

Update hwloc submodule to fix "make distcheck" #7449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2020

Conversation

jsquyres
Copy link
Member

@jsquyres jsquyres commented Feb 21, 2020

Hwloc upstream has fixed a problem with embedded "make distcheck" that
was breaking that surfaced when you ran autogen in an Open MPI
tarball.

This submodule update takes in the upstream hwloc fixes for this
issue.

Signed-off-by: Jeff Squyres [email protected]

Fixes #7363

@jsquyres
Copy link
Member Author

@bgoglin just pointed out to me that this is not upstream in the hwloc repo yet. So -- do not merge yet!

@jjhursey
Copy link
Member

bot:ibm:retest

@open-mpi open-mpi deleted a comment from ibm-ompi Feb 21, 2020
@open-mpi open-mpi deleted a comment from ibm-ompi Feb 21, 2020
@ibm-ompi
Copy link

The IBM CI (GNU/Scale) build failed! Please review the log, linked below.

Gist: https://gist.github.com/ibm-ompi/88b480fb98dfd2bdac939f023e1f8fe6

@ibm-ompi
Copy link

The IBM CI (XL) build failed! Please review the log, linked below.

Gist: https://gist.github.com/ibm-ompi/88b480fb98dfd2bdac939f023e1f8fe6

@jsquyres
Copy link
Member Author

@jjhursey The problem is that the git hash isn't upstream in the hwloc repo yet (which I didn't realize when I made the PR). It'll fail until @bgoglin pushes the commit upstream.

@bgoglin
Copy link
Contributor

bgoglin commented Feb 21, 2020

Pushed in upstream hwloc v2.1 branch as commit 67b2c0368cdd5e0b66476fd4222adaf8f8bac7e0
Sorry Jeff, you need to update the submodule again.

Hwloc upstream has fixed a problem with embedded "make distcheck" that
was breaking that surfaced when you ran autogen in an Open MPI
tarball.

This submodule update takes in the upstream hwloc fixes for this
issue.

Signed-off-by: Jeff Squyres <[email protected]>
@jsquyres jsquyres force-pushed the pr/update-hwloc-to-fix-make-dist branch from 7d7aeb9 to cdd3a9f Compare February 21, 2020 21:07
@jsquyres jsquyres merged commit 7c76237 into open-mpi:master Feb 22, 2020
@jsquyres jsquyres deleted the pr/update-hwloc-to-fix-make-dist branch February 22, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"autogen.pl --force" fails in master tarball due to missing hwloc dirs
4 participants