[Refactor] Refactor COCOMetric, CocoOccludedSeparatedMetric, and ProposalRecallMetric by using MMEval#9079
Open
BIGWangYuDong wants to merge 19 commits intoopen-mmlab:refactor_metricsfrom
Open
Conversation
Collaborator
Author
RangiLyu
reviewed
Feb 27, 2023
Collaborator
Author
|
Supporting saving coco summarize information |
RangiLyu
reviewed
Feb 27, 2023
RangiLyu
reviewed
Feb 27, 2023
RangiLyu
reviewed
Feb 27, 2023
RangiLyu
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Follor PR: open-mmlab/mmeval#23 and open-mmlab/mmeval#29
should be merged after open-mmlab/mmeval#98 and open-mmlab/mmeval#112 has been merged
CocoMetric
Before refactor
After refactor
Not load ann_file:
The area in coco is based on gt_mask. if using gt_bbox, it will lead to different small/medium/large AP results. Moreover, the area calculated from gt_mask area in CocoDetectionMetric is almost equal to coco-json file (still a little difference in small AP). So if only calculate bbox ap, and do not load ann_file, it is suggested to load mask at the same time.
Using gt_box area:

Using gt_mask area:

Load ann_file:
ProposalRecallMetric
Before refactor
After refactor
CocoOccludedSeparatedMetric
Before refactor
After refactor