-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
@billburnseh this looks good to me. We should probably get at least one other person to look at it before we merge it. You might want to explicitly add some folks as reviewers. |
Thanks, added Marcel... |
If you want to add me, you can summon me by tagging me as @durandom or request a review in the upper right corner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 besides some nitpicks
1st version of the getting started content
New content, but Incorporates comments made on earlier version of this readme.
All changes addressed by taking changes or due to the content being replaced. |
I believe all changes requested have been made and/or the new content eliminated the items. Fire away with any new items. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for new requests! I like it 👍 🙂
@billburnseh maybe you can squash those commits into one? But that's just a nitpick, you can squash on merge. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content changed and relevant comments to the new content were incorporated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, let's get it
Creating initial content for the readme file.