Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Update README.md #1

Merged
merged 16 commits into from
Mar 30, 2021
Merged

Conversation

billburnseh
Copy link
Contributor

Creating initial content for the readme file.

@billburnseh billburnseh closed this Feb 2, 2021
@billburnseh billburnseh reopened this Feb 2, 2021
@larsks larsks self-requested a review February 3, 2021 16:50
@larsks
Copy link

larsks commented Feb 3, 2021

@billburnseh this looks good to me. We should probably get at least one other person to look at it before we merge it. You might want to explicitly add some folks as reviewers.

@billburnseh
Copy link
Contributor Author

Thanks, added Marcel...

@durandom
Copy link
Member

durandom commented Feb 5, 2021

Thanks, added Marcel...

If you want to add me, you can summon me by tagging me as @durandom or request a review in the upper right corner

Copy link
Member

@durandom durandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 besides some nitpicks

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@billburnseh
Copy link
Contributor Author

All changes addressed by taking changes or due to the content being replaced.

@billburnseh billburnseh requested a review from durandom March 18, 2021 13:35
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@billburnseh billburnseh requested review from larsks and tumido March 18, 2021 19:01
@billburnseh
Copy link
Contributor Author

I believe all changes requested have been made and/or the new content eliminated the items. Fire away with any new items.

Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for new requests! I like it 👍 🙂

@tumido
Copy link
Member

tumido commented Mar 19, 2021

@billburnseh maybe you can squash those commits into one? But that's just a nitpick, you can squash on merge. 🙂

Copy link
Contributor Author

@billburnseh billburnseh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content changed and relevant comments to the new content were incorporated.

Copy link
Member

@durandom durandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's get it :shipit:

@durandom durandom merged commit e6a184a into open-infrastructure-labs:main Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants