You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit should fix the cycle_load model in residential.py, reported in #16 . However, calibration for these types of loads should still be done with the new model (updating the cal value in Appliances.py).
Also note the model has some assumptions that could be changed, e.g. that the cycle length and delay are constant throughout the year, and that the power is the mean power assigned for that appliance (this could be sampled instead).
Who could review this? @bramvdh91@SilkeVerbruggen
Also, should I run the calibration for these changes alone, or can it be combined with calibration for the new shower cycles in pull request #17 ? @Mathadon , what's best practice here? Cause the calibration will take hours, it's easiest to only do it once...
I'm not sure what the calibration is so that's hard to answer for me. If the point of the calibration is to detect errors then I would do it individually. Otherwise you can probably do it only once.
The calibration code changes the calibration factors (cal) for each load type (appliance, water flow,..), in order to obtain average annual number of cycles close to the average statistics (given in the definition of each appliance). So this calibration factor influences the probability of activating each appliance.
In fact, I just realize this cal value is not used in the case of cycling loads such as in this model, so the calibration will not make any difference in the result, other than provide some check.
Thus I'd suggest this pull request could be merged, after somebody reviews it, and the calibration is done for #17 instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit should fix the
cycle_loadmodel inresidential.py, reported in #16 . However, calibration for these types of loads should still be done with the new model (updating thecalvalue inAppliances.py).Also note the model has some assumptions that could be changed, e.g. that the cycle length and delay are constant throughout the year, and that the power is the mean power assigned for that appliance (this could be sampled instead).