Skip to content

Conversation

gruebel
Copy link
Member

@gruebel gruebel commented Sep 15, 2025

This PR

  • also added 2 ruff rules to make sure those aliases won't be imported again

@gruebel gruebel requested review from a team as code owners September 15, 2025 20:56
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @gruebel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the codebase's type hinting consistency and maintainability. It systematically replaces older, deprecated typing aliases with their modern collections.abc equivalents across various files. To ensure adherence to these new standards, two new Ruff linting rules have been integrated, which will help prevent the reintroduction of these deprecated aliases in the future. These changes contribute to a more robust and future-proof type-checking environment.

Highlights

  • Type Hint Modernization: Replaced deprecated typing aliases (such as typing.Mapping, typing.Callable, typing.Sequence, typing.Optional, typing.Union, and typing.TYPE_CHECKING) with their more explicit collections.abc counterparts or direct typing module access where appropriate across the codebase.
  • Ruff Rule Enforcement: Introduced two new Ruff rules (ICN003 and TID251) in pyproject.toml to prevent future use of these deprecated typing aliases and enforce the use of collections.abc for common abstract base classes, ensuring consistent type-hinting practices.
  • Minor Code Refinements: Included small improvements such as using .copy() for list duplication instead of slicing [:] and employing the in operator for string containment checks, enhancing code clarity and Pythonic style.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.86%. Comparing base (de37144) to head (ea717f2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #537   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files          39       39           
  Lines        1823     1823           
=======================================
  Hits         1784     1784           
  Misses         39       39           
Flag Coverage Δ
unittests 97.86% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces deprecated typing aliases with their collections.abc counterparts, which is a great improvement for future Python compatibility. The addition of ruff rules to enforce this is also a good step towards maintaining code quality.

My review includes a few suggestions:

  • In openfeature/event.py, I've pointed out some redundant field definitions in a dataclass that can be simplified.
  • In pyproject.toml, I've found a couple of issues with the new ruff configuration that would prevent the new linting rules from working as intended.

The rest of the changes look good and are applied consistently across the codebase.

@gruebel gruebel merged commit 837fef9 into main Sep 21, 2025
16 checks passed
@gruebel gruebel deleted the replace-type-alias branch September 21, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants