Skip to content

fix(envconfig): rename CLUSTER_DOMAIN env var to FLAGD_CLUSTER_DOMAIN #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kuznero wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(envconfig): rename CLUSTER_DOMAIN env var to FLAGD_CLUSTER_DOMAIN #792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7ff3551
feat: add configurable cluster domain support
kuznero Nov 23, 2025
82eab83
Merge branch 'main' of https://github.com/open-feature/open-feature-o…
kuznero Jan 6, 2026
d95d6c2
fix(envconfig): rename CLUSTER_DOMAIN env var to FLAGD_CLUSTER_DOMAIN
kuznero Jan 6, 2026
bac2147
fix(envconfig): rename ClusterDomain field to FlagdClusterDomain
kuznero Jan 6, 2026
4661f36
fix: keep ClusterDomain field name in FlagdProxyConfiguration
kuznero Jan 6, 2026
486dfc4
style: fix struct field alignment in test
kuznero Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/common/flagdproxy/flagdproxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func NewFlagdProxyConfiguration(env types.EnvConfig, imagePullSecrets []string,
ImagePullSecrets: imagePullSecrets,
Labels: labels,
Annotations: annotations,
ClusterDomain: env.ClusterDomain,
ClusterDomain: env.FlagdClusterDomain,
}
}

Expand Down
2 changes: 1 addition & 1 deletion internal/common/flagdproxy/flagdproxy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ func TestNewFlagdProxyConfiguration(t *testing.T) {
FlagdProxyPort: 8015,
FlagdProxyManagementPort: 8016,
FlagdProxyReplicaCount: 123,
ClusterDomain: "cluster.local",
FlagdClusterDomain: "cluster.local",
}, pullSecrets, labels, annotations)

require.NotNil(t, kpConfig)
Expand Down
2 changes: 1 addition & 1 deletion internal/common/types/envconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ type EnvConfig struct {
FlagdProxyPort int `envconfig:"FLAGD_PROXY_PORT" default:"8015"`
FlagdProxyManagementPort int `envconfig:"FLAGD_PROXY_MANAGEMENT_PORT" default:"8016"`
FlagdProxyDebugLogging bool `envconfig:"FLAGD_PROXY_DEBUG_LOGGING" default:"false"`
ClusterDomain string `envconfig:"CLUSTER_DOMAIN" default:"cluster.local"`
FlagdClusterDomain string `envconfig:"FLAGD_CLUSTER_DOMAIN" default:"cluster.local"`

FlagdImage string `envconfig:"FLAGD_IMAGE" default:"ghcr.io/open-feature/flagd"`
// renovate: datasource=github-tags depName=open-feature/flagd/flagd
Expand Down
Loading