Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: generate crd docs #448

Merged
merged 6 commits into from
Apr 12, 2023
Merged

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Apr 6, 2023

This PR

see generated docs here

Related Issues

Fixes #392

@RealAnna RealAnna changed the title Ci/document crd ci: generate crd docs Apr 6, 2023
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #448 (68109f0) into main (b23edef) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #448   +/-   ##
=======================================
  Coverage   78.38%   78.38%           
=======================================
  Files          21       21           
  Lines        1346     1346           
=======================================
  Hits         1055     1055           
  Misses        251      251           
  Partials       40       40           
Flag Coverage Δ
unit-tests 78.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@RealAnna RealAnna marked this pull request as ready for review April 6, 2023 11:16
@RealAnna RealAnna requested a review from a team as a code owner April 6, 2023 11:17
Makefile Outdated Show resolved Hide resolved
@Kavindu-Dodan
Copy link
Contributor

General suggestion - let's update the Contribution guide [1] to highlight the need of make generate-crdocs for API changes :)

[1] - https://github.com/open-feature/open-feature-operator/blob/main/CONTRIBUTING.md

Signed-off-by: realanna <[email protected]>

ci: typo

Signed-off-by: realanna <[email protected]>

ci: typo

Signed-off-by: realanna <[email protected]>

ci: cleanup copypasta

Signed-off-by: realanna <[email protected]>

ci: cleanup copypasta

Signed-off-by: realanna <[email protected]>

ci: cleanup copypasta

Signed-off-by: realanna <[email protected]>

ci: generate crd

Signed-off-by: realanna <[email protected]>

ci: generate crd

Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
@james-milligan james-milligan merged commit cee89a3 into open-feature:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically generate CRD docs
5 participants