fix(flipt): set variant attachment as value for object evaluation #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Phelps <[email protected]>
markphelps
force-pushed
the
update-flipt-provider
branch
from
7de7ec9
to
cd7a61a
Compare
github-actions
bot
requested review from
beeme1mr,
Kavindu-Dodan,
thisthat and
toddbaert
Signed-off-by: Mark Phelps <[email protected]>
markphelps
force-pushed
the
update-flipt-provider
branch
from
170a1fa
to
d0c6222
Compare
liran2000
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
looks good to me.
can adjust the readme section accordingly to something like:
- Boolean evaluation gets feature boolean evaluation / enabled status.
- Object evaluation gets variant attachment.
- Other evaluations gets feature variant key.
Signed-off-by: Mark Phelps <[email protected]>
|
@liran2000 done! ty! |
toddbaert
approved these changes
Sep 25, 2024
beeme1mr
approved these changes
Oct 1, 2024
|
Sorry for the delay @markphelps. Unfortunately, it looks like there are some merge conflicts that can't be resolved in GitHub. Could you please take a look when you have a moment? |
Signed-off-by: Mark Phelps <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #955
Notes
Follow-up Tasks
How to test