feat: add Prefab provider #1325
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
# Conflicts: # .github/component_owners.yml # .release-please-manifest.json # pom.xml
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
aepfli
approved these changes
Apr 24, 2025
|
Thank you. To be clear, I did not check the implementation itself. This is something that I can't challenge with too little insight. But the project setup looks great, and none of the dependencies used look suspicious to me ;). Just to be clear about what my approval means ;) and what was in my focus ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readme describes the provider.
solves issue 123.
* by prev. #915, as Java 11 is now supported by #1303
@jkebinger you are welcome to review