feat: improve error handling #1214
Open
+15
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikzz3
force-pushed
the
feat/improve-error-handling
branch
from
5456729 to
e9405c1
Compare
Signed-off-by: Nick Zimmermann <[email protected]>
Signed-off-by: Todd Baert <[email protected]> Signed-off-by: Nick Zimmermann <[email protected]>
…pen-feature#1215) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Nick Zimmermann <[email protected]>
Signed-off-by: Todd Baert <[email protected]> Signed-off-by: Nick Zimmermann <[email protected]>
…pen-feature#1217) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Nick Zimmermann <[email protected]>
Signed-off-by: christian.lutnik <[email protected]> Signed-off-by: Nick Zimmermann <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]> Signed-off-by: Nick Zimmermann <[email protected]>
…pen-feature#1221) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Nick Zimmermann <[email protected]>
…ure#1218) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Nick Zimmermann <[email protected]>
…pen-feature#1198) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Nick Zimmermann <[email protected]>
…open-feature#1223) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Nick Zimmermann <[email protected]>
Signed-off-by: Nick Zimmermann <[email protected]>
Nikzz3
force-pushed
the
feat/improve-error-handling
branch
from
c09cf24 to
503fbbc
Compare
github-actions
bot
requested review from
beeme1mr,
Kavindu-Dodan,
thisthat and
toddbaert
beeme1mr
approved these changes
Feb 19, 2025
toddbaert
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Makes sense to me.
cc @thomaspoignant (but I'm confident this is right so I'll merge in a few days unless I hear otherwise)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error handling
This PR improves error handling for 400 and 500 error codes. It returns the message to the user from the response payload.
How to test
When the providers receives an error (400 or 500), the provider must show the message of the response payload.