-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add OpenFeature.Extensions.Hosting package #181
feat: Add OpenFeature.Extensions.Hosting package #181
Conversation
c798fc8
to
c295dd0
Compare
aa8544b
to
a9fd12e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
- Coverage 95.40% 90.82% -4.59%
==========================================
Files 27 29 +2
Lines 1111 1068 -43
Branches 120 113 -7
==========================================
- Hits 1060 970 -90
- Misses 34 70 +36
- Partials 17 28 +11 ☔ View full report in Codecov by Sentry. |
FYI couple of known test failures:
|
a9fd12e
to
9821a5b
Compare
9821a5b
to
2eb7335
Compare
828cebb
to
cf419bd
Compare
7fb289d
to
a2cde68
Compare
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
# Conflicts: # Directory.Packages.props # README.md
… Fix unit tests. Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
# Conflicts: # Directory.Packages.props
Signed-off-by: André Silva <[email protected]>
# Conflicts: # README.md
# Conflicts: # README.md
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
# Conflicts: # Directory.Packages.props
Signed-off-by: André Silva <[email protected]>
Is this PR going to be merged? I was looking forward to this capabilities with version 2.0 |
|
||
<PropertyGroup> | ||
<Nullable>enable</Nullable> | ||
<TargetFrameworks>netstandard2.0;net6.0;net7.0;net8.0;net462</TargetFrameworks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should .NET 7 be included as TFM? .NET 7 is out of official support
/// Describes a <see cref="OpenFeatureBuilder"/> backed by an <see cref="IServiceCollection"/>. | ||
/// </summary> | ||
/// <param name="Services"><see cref="IServiceCollection"/></param> | ||
public sealed record OpenFeatureBuilder(IServiceCollection Services); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason to go for a record and the extension methods here? I am not too deep into .NET but I have not seen that pattern formerly.
Superseded by #310 |
Closes: #264
Related
TODO:
IHostingEnvironment
sample