chore: Fix props to support more than one project #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main open-feature/dotnet-sdk-contrib#177 +/- ##
=========================================
+ Coverage 0 93.86% +93.86%
=========================================
Files 0 23 +23
Lines 0 946 +946
Branches 0 105 +105
=========================================
+ Hits 0 888 +888
- Misses 0 34 +34
- Partials 0 24 +24 ☔ View full report in Codecov by Sentry. |
|
Built this locally and everything looks sane to me! |
toddbaert
approved these changes
Jan 16, 2024
beeme1mr
approved these changes
Jan 16, 2024
austindrenski
force-pushed
the
update-packaging-config-to-support-multiple-projects
branch
from
90407e8
to
37f7d10
Compare
austindrenski
force-pushed
the
update-packaging-config-to-support-multiple-projects
branch
from
37f7d10
to
cbd22d9
Compare
Ran across this while working on open-feature/dotnet-sdk-contrib#127, and tldr; if there's more than one project under `src/`, having the `<PackageId>` hard-coded in `build/Common.prod.props` causes MSBuild to panic. There are two options to fix this: 1. ```diff - <PackageId>OpenFeature</PackageId> + <PackageId>$(MSBuildProjectName)</PackageId> ``` 2. ```diff - <PackageId>OpenFeature</PackageId> ``` Since NuGet defaults `PackageId` to the assembly name, I'm opting for (2), but if I've overlooked some nuance/custom build steps that require setting `PackageId` explicitly, then we could just as well fallback to (1). Signed-off-by: Austin Drenski <[email protected]>
toddbaert
force-pushed
the
update-packaging-config-to-support-multiple-projects
branch
from
cbd22d9
to
71230e8
Compare
austindrenski
deleted the
update-packaging-config-to-support-multiple-projects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran across this while working on #264, and tldr; if there's more than one project under
src/, having the<PackageId>hard-coded inbuild/Common.prod.propscauses MSBuild to panic.There are two options to fix this:
- <PackageId>OpenFeature</PackageId>Since NuGet defaults
PackageIdto the assembly name, I'm opting for (2), but if I've overlooked some nuance/custom build steps that require settingPackageIdexplicitly, then we could just as well fallback to (1).Example
Related