Use try-finally for disable/enable versioning#97
Merged
solverat merged 10 commits intoopen-dxp:1.xfrom Feb 25, 2026
Merged
Conversation
Review Checklist
|
Contributor
Author
|
@solverat Here is the PR :) |
Contributor
|
@blankse Thanks for the quick response! I'll merge it for now. We may should consider outsourcing this method to a Helper and use it here too: opendxp/models/Asset/Video.php Lines 199 to 201 in e3c5961 opendxp/models/Asset/Video.php Lines 228 to 230 in e3c5961 opendxp/models/Element/Recyclebin/Item.php Lines 108 to 119 in e3c5961 opendxp/lib/Messenger/Handler/AssetUpdateTasksHandler.php Lines 66 to 69 in e3c5961 |
jdreesen
reviewed
Feb 25, 2026
Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
jdreesen
reviewed
Feb 25, 2026
Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
solverat
approved these changes
Feb 25, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #95