Conversation
…saveWithoutVersion` helper, and enhance error handling logic.
Review Checklist
|
benwalch
approved these changes
Feb 25, 2026
blankse
reviewed
Feb 25, 2026
Comment on lines
+330
to
+339
| $versioningEnabled = Model\Version::isEnabled(); | ||
| if ($versioningEnabled) { | ||
| Model\Version::disable(); | ||
| } | ||
|
|
||
| $asset->save(); | ||
|
|
||
| if ($versioningEnabled) { | ||
| Model\Version::enable(); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| $versioningEnabled = Model\Version::isEnabled(); | |
| if ($versioningEnabled) { | |
| Model\Version::disable(); | |
| } | |
| $asset->save(); | |
| if ($versioningEnabled) { | |
| Model\Version::enable(); | |
| } | |
| $versioningEnabled = Model\Version::isEnabled(); | |
| try { | |
| if ($versioningEnabled) { | |
| Model\Version::disable(); | |
| } | |
| $asset->save(); | |
| } finally { | |
| if ($versioningEnabled) { | |
| Model\Version::enable(); | |
| } | |
| } |
Contributor
Author
There was a problem hiding this comment.
@blankse Oh no, that was too close! Your proposal makes perfect sense. Could you please submit another PR for that?
Contributor
Author
There was a problem hiding this comment.
@blankse wait, i just have seen this:
https://github.com/search?q=repo%3Aopen-dxp%2Fopendxp%20version%3A%3Aenable()&type=code
maybe we should change this globally...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #94