Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Add a security insights doc #888

Conversation

zhujian7
Copy link
Member

Summary

Related issue(s)

Fixes #863

@openshift-ci openshift-ci bot requested review from deads2k and jnpacker March 12, 2025 13:24
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.71%. Comparing base (a5f3912) to head (d963d84).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #888      +/-   ##
==========================================
- Coverage   63.77%   63.71%   -0.06%     
==========================================
  Files         193      192       -1     
  Lines       18977    18919      -58     
==========================================
- Hits        12102    12055      -47     
+ Misses       5881     5871      -10     
+ Partials      994      993       -1     
Flag Coverage Δ
unit 63.71% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mikeshng
Copy link
Member

/assign @mikeshng

Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we need to update some of the links or leave it because you must have copied them from some where.

@mikeshng
Copy link
Member

CC @pshickeydev

@zhujian7 zhujian7 force-pushed the security-insights branch from 1a357d5 to c0c0911 Compare March 17, 2025 02:30
@zhujian7
Copy link
Member Author

oh @mikeshng thanks for pointing that out. Actually, I had one local commit that I forgot to push. 😓
PTAL

Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

/hold

Feel free to unhold when #876 is merged

Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 17, 2025
@qiujian16
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Apr 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 1, 2025
@zhujian7
Copy link
Member Author

zhujian7 commented Apr 1, 2025

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit c969dbe into open-cluster-management-io:main Apr 1, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OCM Incubation] Add a security-insights.yml
3 participants