feat: Implement the manifestwork ignoreFields #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikeshng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mikeshng
changed the title
… operation field to allow for manual sync and appset progressive sync to work properly Signed-off-by: Mike Ng <[email protected]>
mikeshng
changed the title
|
/assign @fxiang1 |
|
/lgtm |
openshift-merge-bot
bot
merged commit ae472b8
into
open-cluster-management-io:main
5 checks passed
|
@mikeshng Everything looks good. If this is also going to downstream, you might want to check with the build team to see if they support Go 1.24. Thanks! |
Thanks. This repo is upstream only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Implement the manifestwork ignoreFields feature for application operation field to allow for manual sync and appset progressive sync to work properly