Don't set up more than 1 abort signal listener #503
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤦 Rxjs'
fromEvent
creates a new listener on every subscription, but this is a bit hidden because the abort signal isn't subscribed to directly:concurrently/src/completion-listener.ts
Lines 96 to 109 in a7a5894
Sounds like just sharing the underlying source observable is enough.
Fixes #502