You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
I think node v0.12 was dropped in v3.0.0. My reasoning is that it was removed from travis on Sept 19, 2016, and 3.0.0 was on Sept 26, 2016. I think that's because the breaking changes happened then.
v0.12 was added back to travis later, but I don't think the builds were passing.
I think @gustavohenke's changes are okay since they're just reflecting the current state of the repo 😃
7661fc4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes me a tad nervous that you drop support for Node v0.12.x in a minor version bump. Was this an oversight or do you not follow semver?
7661fc4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The builds weren't passing :(
7661fc4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think node v0.12 was dropped in v3.0.0. My reasoning is that it was removed from travis on Sept 19, 2016, and 3.0.0 was on Sept 26, 2016. I think that's because the breaking changes happened then.
v0.12 was added back to travis later, but I don't think the builds were passing.
I think @gustavohenke's changes are okay since they're just reflecting the current state of the repo 😃
7661fc4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks for the clarification friends!