Skip to content

improve error for type mismatch #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

improve error for type mismatch #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/open_api_spex/cast/enum.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ defmodule OpenApiSpex.Cast.Enum do
alias OpenApiSpex.Cast

def cast(ctx = %Cast{schema: %{enum: enum}, value: value}) do
case Enum.find(enum, {:error, :invalid_enum}, &equivalent?(&1, value)) do
{:error, :invalid_enum} -> Cast.error(ctx, {:invalid_enum})
case Enum.find(enum, {:error, :invalid_enum, enum, value}, &equivalent?(&1, value)) do
{:error, :invalid_enum, enum, value} -> Cast.error(ctx, {:invalid_enum, enum, value})
found -> {:ok, found}
end
end
Expand Down
10 changes: 6 additions & 4 deletions lib/open_api_spex/cast/error.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ defmodule OpenApiSpex.Cast.Error do
@type t :: %__MODULE__{
reason: reason(),
value: any(),
enum: any(),
format: String.t(),
name: String.t(),
path: list(String.t()),
Expand All @@ -100,6 +101,7 @@ defmodule OpenApiSpex.Cast.Error do

defstruct reason: nil,
value: nil,
enum: [],
format: nil,
type: nil,
name: nil,
Expand Down Expand Up @@ -196,8 +198,8 @@ defmodule OpenApiSpex.Cast.Error do
|> add_context_fields(ctx)
end

def new(ctx, {:invalid_enum}) do
%__MODULE__{reason: :invalid_enum}
def new(ctx, {:invalid_enum, enum, value}) do
%__MODULE__{reason: :invalid_enum, enum: enum, value: value}
|> add_context_fields(ctx)
end

Expand Down Expand Up @@ -329,8 +331,8 @@ defmodule OpenApiSpex.Cast.Error do
"Invalid format. Expected #{inspect(format)}"
end

def message(%{reason: :invalid_enum}) do
"Invalid value for enum"
def message(%{reason: :invalid_enum, enum: enum, value: value}) do
"Invalid value for enum, allowed_values: #{inspect(enum)}, got: #{inspect(value)}"
end

def message(%{reason: :polymorphic_failed, type: polymorphic_type}) do
Expand Down