Update paths to GenAIInfra scripts #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eero-t
requested review from
chensuyue,
chickenrae,
ftian1,
mkbhanda and
preethivenkatesh
as code owners
eero-t
force-pushed
the
fix-paths
branch
3 times, most recently
from
12babb7 to
eb81b57
Compare
1 task
yongfengdu
approved these changes
May 9, 2025
ZePan110
approved these changes
May 9, 2025
And improve surrounding text slightly. Signed-off-by: Eero Tamminen <[email protected]>
- fix: fork name != "docs" - check URLs only once - more error output - shorter timeouts Signed-off-by: Eero Tamminen <[email protected]>
Contributor
Author
|
Rebased to latest |
Contributor
Author
Note that I added shorter (15s) link check timeouts only for the first 2 attempts on given link. At end the, current code will try all failed links again 5 times, with 10s sleep between them. So for every non-existing link, the script will take in total 2*15s + 5 * (30s+10s) = nearly 4 minutes. Making sure that's done only for unique links helps, but maybe number of those attempts should also be decreased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update script paths in docs to match opea-project/GenAIInfra#1041 PR, slightly improve surrounding text, and fix+improve CI test script that checks doc URLs.