Fix string comparison in HybridRAG test script #2004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abolfazl Shahbazi <[email protected]>
ashahba
requested review from
lvliang-intel,
ftian1,
chensuyue,
lkk12014402,
minmin-intel and
rbrugaro
as code owners
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
eero-t
approved these changes
May 30, 2025
There was a problem hiding this comment.
Approved, but this is Bash specific syntax. Shell string comparison operator is = in the POSIX standard (which is naturally accepted also by Bash): https://stackoverflow.com/questions/1089813/bash-dash-and-string-comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are multiple string comparisons in
HybridRAG/tests/test_compose_on_gaudi.shthat use-eqwhich is meant to be used for numerical comparisons.Issues
N/A
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
N/A
Tests
The test script itself should remain working.