[OD-128] PostBase 컴포넌트 오류 해결 #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
고생했다아 ~~~ |
gustn99
reviewed
Nov 30, 2024
Comment on lines
197
to
198
| // 유저 차단 api | ||
| const sendBlock = async () => { |
Collaborator
There was a problem hiding this comment.
api호출함수에 맞춰서 postUserBlock으로 수정해주세용
Comment on lines
232
to
259
| ? [ | ||
| { | ||
| text: '삭제', | ||
| action: () => { | ||
| setIsCommentDeleteConfirmationModalOpen(true); | ||
| setIsMenuVisible(false); | ||
| }, | ||
| icon: Delete, | ||
| color: 'red', | ||
| }, | ||
| ] | ||
| : [ | ||
| { | ||
| text: '신고하기', | ||
| action: () => { | ||
| setIsCommentReportModalOpen(true); | ||
| }, | ||
| icon: Report, | ||
| }, | ||
| { | ||
| text: '차단하기', | ||
| action: () => { | ||
| setIsBlockConfirmationModalOpen(true); | ||
| setIsMenuVisible(false); | ||
| }, | ||
| icon: Block, | ||
| }, | ||
| ]), |
Collaborator
There was a problem hiding this comment.
내 댓글 메뉴와 다른 사람 댓글 메뉴에 대한 객체 배열을 별도의 변수로 분리해서 작성하면 가독성이 좋아질 것 같아용 한번 고려해 보시고 더 괜찮은 방식으로 사용하시면 될 것 같습니다!!
Comment on lines
-5
to
+9
| import { UserBlockAtom } from '../../../recoil/Home/BlockBottomSheetAtom'; | ||
| import { | ||
| IsCommentDeleteConfirmationModalOpenAtom, | ||
| IsCommentReportModalOpenAtom, | ||
| selectedCommentAtom, | ||
| } from '../../../recoil/Post/PostCommentAtom'; |
Collaborator
There was a problem hiding this comment.
/recoil/Home/BlockBottomSheetAtom 더 이상 사용 안 하시면 삭제해 주세요! Home 폴더 자체를 삭제하면 될 것 같습니다~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
주요 작업 내용
(댓글 api 및 모달 띄우는 로직이 CommentItem 밖에 있는 게 더 적절한 듯 하여..)
기타 작업 내용
(ClothingInfoItem을 매핑하는 컨테이너에서 gap을 주는 것으로 변경)
(content 더보기를 눌렀을 때 사진이 아래로 밀리는게 안좋은 것 같아서.. content를 맨 밑으로 내렸습니다.)
코드 리뷰 포인트
작업 화면
내 댓글 메뉴 버튼 클릭시
다른 유저 댓글 메뉴 버튼 클릭 시