Skip to content

[OD-152] matching & chatting 도메인 api 응답 수정 #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gustn99 merged 5 commits into from
Dec 28, 2024
Merged

[OD-152] matching & chatting 도메인 api 응답 수정 #115

gustn99 merged 5 commits into from
Dec 28, 2024

Conversation

@gustn99
Copy link
Collaborator

@gustn99 gustn99 commented Dec 28, 2024 •
edited
Loading

주요 작업 내용

  • matching & chatting 도메인 api 응답 수정했습니다. Chats 및 Home 컴포넌트 외에는 영향을 받은 컴포넌트가 없습니다!

기타 작업 내용

  • 예전에 서버 응답이 opponentInfo에서 otherUser로 변경되면서 dto도 수정되었었는데, 충돌 이슈로 recoil로 관리하는 전역변수 oponentInfo를 계속 사용하다가 이번에 otherUser로 변경했습니다.
  • Comment 컴포넌트에 type 키워드가 누락된 부분을 발견해 수정했습니다.

코드 리뷰 포인트

  • 프로필 컴포넌트 작업하실 때 미리 풀 받으셔서 opponentInfo가 아닌 otherUser를 사용해 주시기 바랍니다!

작업 화면

  • 없음

@gustn99 gustn99 added fix Fix bugs that don't work refactor Improve code structure and readability labels Dec 28, 2024
@gustn99 gustn99 requested a review from lalaurrel December 28, 2024 12:47
@gustn99 gustn99 self-assigned this Dec 28, 2024
@gustn99 gustn99 merged commit ff0c36b into dev Dec 28, 2024
1 check passed
@gustn99 gustn99 deleted the feat/OD-152 branch December 28, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lalaurrel lalaurrel Awaiting requested review from lalaurrel

Assignees

@gustn99 gustn99

Labels

fix Fix bugs that don't work refactor Improve code structure and readability

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gustn99