[OD-154] user, auth 도메인 response 응답에 따라 dto 수정 #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustn99
reviewed
Dec 28, 2024
Collaborator
gustn99
left a comment
gustn99
left a comment
There was a problem hiding this comment.
dto 임포트 시 type이 빠진 부분이 보여 코멘트 남겼습니다! 상대경로에만 type을 추가하신 것으로 보이는데, 절대경로에도 붙여주셔야 하니 혹시 다른 부분들도 누락되진 않았는지 한번 점검 부탁드려요!
src/apis/user/dto.ts
Outdated
| @@ -1,15 +1,15 @@ | |||
| import { BaseSuccessResponse } from '../core/dto'; | |||
| import { BaseSuccessResponse } from '@apis/core/dto'; | |||
Collaborator
There was a problem hiding this comment.
156번 브랜치에서도 type 키워드 관련 누락이 보였으나 154번 브랜치에서 일괄 처리하시는 것이 편리하실 것 같아 156번은 머지했습니다! 풀 받으시고 user block, user report 도메인 부분에서도 절대경로 dto에 대해 type 키워드 추가해 주세용
src/apis/auth/dto.ts
Outdated
| @@ -1,14 +1,15 @@ | |||
| import { BaseSuccessResponse } from '../core/dto'; | |||
| import { BaseSuccessResponse } from '@apis/core/dto'; | |||
src/apis/user/index.ts
Outdated
| import { newRequest } from '../core'; | ||
| import { EmptySuccessResponse } from '../core/dto'; | ||
| import { newRequest } from '@apis/core'; | ||
| import { EmptySuccessResponse } from '@apis/core/dto'; |
Collaborator
Author
There was a problem hiding this comment.
모두 수정했습니다 프엔장 님...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
주요 작업 내용
기타 작업 내용
코드 리뷰 포인트
작업 화면