Coverage: no ratio when the supplier lists no documents - #337
Merged
Merged
Conversation
A check of 0 supplier documents published ratio 1, which read as complete. Leiden, Zaanstad and Purmerend show exactly that while their content ends in 2022 or 2025. The ratio is now null in that case, like for a failed check.
joepio
marked this pull request as ready for review
October 5, 2026 10:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: a coverage check where the supplier listed 0 documents in the window published
ratio: 1, which reads as complete. Leiden, Zaanstad and Purmerend show exactly that in/api/statuswhile their newest content ends in March 2022, December 2022 and June 2025.After:
ratioisnullwhensupplierDocumentsis 0, the same "unknown" a failed check already gives. The numbers stay as measured.The ratio of 0 held over 0 says nothing about completeness. It is also what a source looks like when it publishes through a module we do not read or elsewhere altogether.
How:
toSourceCoverageinweb/status_api.tsreturnsnullinstead of 1, with a test intests/coverage_check.test.ts.SourceCoveragedocs insrc/types.tsandAPI.mddescribe the new case.Refs the question from Sander Bakker's forwarded mail on Notubiz, Parlaeus and Velsen.
Generated by Claude Code