add operator config for execution result query Criteria #8048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mts1715
changed the title
peterargue
reviewed
Oct 16, 2025
| flags.UintVar(&builder.executionResultAgreeingExecutorsCount, | ||
| "execution-result-agreeing-executors-count", | ||
| defaultConfig.executionResultAgreeingExecutorsCount, | ||
| "minimum number of execution receipts with the same result required for execution result queries") |
There was a problem hiding this comment.
Can you add a validation to make sure the provided number is greater than or equal to 1? That should go in the ValidateFlags function
| node.State, | ||
| node.Storage.Receipts, | ||
| execNodeSelector, | ||
| optimistic_sync.DefaultCriteria, |
There was a problem hiding this comment.
DefaultCriteria is also passed to the backend params as the OperatorCriteria field. I don't think we need that field anymore. can you remove it from the params struct?
|
added a couple small comments, but looks great! |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
… as OperatorCriteria
peterargue
reviewed
Oct 17, 2025
| ExecutionResultInfoProvider: execResultInfoProvider, | ||
| ExecutionStateCache: execStateCache, | ||
| OperatorCriteria: optimistic_sync.DefaultCriteria, | ||
| OperatorCriteria: operatorCriteria, |
There was a problem hiding this comment.
can you just remove this field entirely. It's unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7879
Added two config operators to access-node cli
These parameters are passed to the ExecutionResultInfoProvider as criteria during the RPC Engine building.