Skip to content

Remove transaction retry functionality from Access RPC backend #8043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove transaction retry functionality from Access RPC backend #8043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efd2883
Remove transaction retry functionality from Access RPC backend
devin-ai-integration[bot] Oct 15, 2025
43fbf64
Remove RetryEnabled from observer node builder
devin-ai-integration[bot] Oct 15, 2025
59320d6
Remove retrier entry from mockery configuration
devin-ai-integration[bot] Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .mockery.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ packages:
github.com/onflow/flow-go/engine/access/rpc/backend/node_communicator:
github.com/onflow/flow-go/engine/access/rpc/backend/transactions/error_messages:
github.com/onflow/flow-go/engine/access/rpc/backend/transactions/provider:
github.com/onflow/flow-go/engine/access/rpc/backend/transactions/retrier:
github.com/onflow/flow-go/engine/access/rpc/connection:
github.com/onflow/flow-go/engine/access/state_stream:
github.com/onflow/flow-go/engine/access/subscription:
Expand Down
4 changes: 0 additions & 4 deletions cmd/access/node_builder/access_node_builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ type AccessNodeConfig struct {
logTxTimeToExecuted bool
logTxTimeToFinalizedExecuted bool
logTxTimeToSealed bool
retryEnabled bool
rpcMetricsEnabled bool
executionDataSyncEnabled bool
publicNetworkExecutionDataEnabled bool
Expand Down Expand Up @@ -253,7 +252,6 @@ func DefaultAccessNodeConfig() *AccessNodeConfig {
logTxTimeToFinalizedExecuted: false,
logTxTimeToSealed: false,
pingEnabled: false,
retryEnabled: false,
rpcMetricsEnabled: false,
nodeInfoFile: "",
apiRatelimits: nil,
Expand Down Expand Up @@ -1288,7 +1286,6 @@ func (builder *FlowAccessNodeBuilder) extraFlags() {
"ping-enabled",
defaultConfig.pingEnabled,
"whether to enable the ping process that pings all other peers and report the connectivity to metrics")
flags.BoolVar(&builder.retryEnabled, "retry-enabled", defaultConfig.retryEnabled, "whether to enable the retry mechanism at the access node level")
flags.BoolVar(&builder.rpcMetricsEnabled, "rpc-metrics-enabled", defaultConfig.rpcMetricsEnabled, "whether to enable the rpc metrics")
flags.UintVar(&builder.TxResultCacheSize, "transaction-result-cache-size", defaultConfig.TxResultCacheSize, "transaction result cache size.(Disabled by default i.e 0)")
flags.StringVarP(&builder.nodeInfoFile,
Expand Down Expand Up @@ -2130,7 +2127,6 @@ func (builder *FlowAccessNodeBuilder) Build() (cmd.Node, error) {
ChainID: node.RootChainID,
AccessMetrics: notNil(builder.AccessMetrics),
ConnFactory: connFactory,
RetryEnabled: builder.retryEnabled,
MaxHeightRange: backendConfig.MaxHeightRange,
Log: node.Logger,
SnapshotHistoryLimit: backend.DefaultSnapshotHistoryLimit,
Expand Down
1 change: 0 additions & 1 deletion cmd/observer/node_builder/observer_builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1973,7 +1973,6 @@ func (builder *ObserverServiceBuilder) enqueueRPCServer() {
ChainID: node.RootChainID,
AccessMetrics: accessMetrics,
ConnFactory: connFactory,
RetryEnabled: false,
MaxHeightRange: backendConfig.MaxHeightRange,
Log: node.Logger,
SnapshotHistoryLimit: backend.DefaultSnapshotHistoryLimit,
Expand Down
2 changes: 0 additions & 2 deletions engine/access/rpc/backend/backend.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ type Params struct {
ChainID flow.ChainID
AccessMetrics module.AccessMetrics
ConnFactory connection.ConnectionFactory
RetryEnabled bool
MaxHeightRange uint
Log zerolog.Logger
SnapshotHistoryLimit int
Expand Down Expand Up @@ -251,7 +250,6 @@ func New(params Params) (*Backend, error) {
HistoricalAccessNodeClients: params.HistoricalAccessNodes,
NodeCommunicator: params.Communicator,
ConnFactory: params.ConnFactory,
EnableRetries: params.RetryEnabled,
NodeProvider: params.ExecNodeIdentitiesProvider,
Blocks: params.Blocks,
Collections: params.Collections,
Expand Down
50 changes: 0 additions & 50 deletions engine/access/rpc/backend/transactions/retrier/mock/retrier.go
View file
Open in desktop

This file was deleted.

47 changes: 0 additions & 47 deletions engine/access/rpc/backend/transactions/retrier/mock/transaction_sender.go
View file
Open in desktop

This file was deleted.

19 changes: 0 additions & 19 deletions engine/access/rpc/backend/transactions/retrier/noop.go
View file
Open in desktop

This file was deleted.

181 changes: 0 additions & 181 deletions engine/access/rpc/backend/transactions/retrier/retrier.go
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion engine/access/rpc/backend/transactions/stream/stream_backend_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,6 @@ func (s *TransactionStreamSuite) initializeBackend() {
HistoricalAccessNodeClients: nil,
NodeCommunicator: nodeCommunicator,
ConnFactory: s.connectionFactory,
EnableRetries: false,
NodeProvider: execNodeProvider,
Blocks: s.blocks,
Collections: s.collections,
Expand Down
Loading
Loading