-
Notifications
You must be signed in to change notification settings - Fork 200
[Access] Implement GetScheduledTransaction* endpoints #8037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
@@ -1,68 +1,55 @@ | |||
package transactions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these tests were completely rewritten, so you can ignore the diff and focus on the new content
// Expected error returns during normal operation: | ||
// - [codes.NotFound]: if the transaction is not a scheduled transaction was not found in the block | ||
// - [codes.Internal]: if there was an error looking up the events |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I took steps towards improving error docs and robust error handling, but didn't try to address everything. that will come as part of the optimistic sync API refactor.
Implement
GetScheduledTransaction
andGetScheduledTransactionResult
endpoints which allow querying transactions and results for scheduled transactions by their uint64id
.This PR also makes the following changes:
GetTransaction
,GetTransactionResult
, andGetTransactionResultByIndex
to allow querying scheduled and system transactions.GetSystemTransaction
andGetSystemTransactionResult
to not allow querying for scheduled transactions since scheduled tx are not system tx.