Skip to content

Conversation

@AndriiDiachuk
Copy link
Contributor

closes: #7656

Context

  • Refactored access and observer builders to initialize newly added members before creating snapshot mock.
  • Updated backend endpoint (GetExecutionDataByBlockID).
  • Added arguments to backend implementation to specify user query criteria.
  • Updated test according to changes.

…a to snapshot interface, refactored access and observer node builders, fixed tests
@AndriiDiachuk AndriiDiachuk self-assigned this Sep 30, 2025
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few small comments. overall this looks good. will wait for the rest of your changes before doing a thorough review

Base automatically changed from illia-malachyn/7652-fork-aware-events-endpoint to feature/optimistic-sync October 6, 2025 10:44
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly small comments. the main 2 were about error handling and bootstrapping. otherwise this looks good

Copy link
Contributor

@UlyanaAndrukhiv UlyanaAndrukhiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I left a few minor comments.

@AndriiDiachuk
Copy link
Contributor Author

@peterargue could you review it today please?

@peterargue
Copy link
Contributor

looks good. please address the conflicts, then we can merge

@peterargue peterargue merged commit 379ae59 into feature/optimistic-sync Oct 30, 2025
113 of 114 checks passed
@peterargue peterargue deleted the andron/7656-fork-aware-execution-data-endpoints branch October 30, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants