-
Notifications
You must be signed in to change notification settings - Fork 200
[DataAvailability] Implement fork-aware Execution Data Endpoints #7985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataAvailability] Implement fork-aware Execution Data Endpoints #7985
Conversation
…a to snapshot interface, refactored access and observer node builders, fixed tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a few small comments. overall this looks good. will wait for the rest of your changes before doing a thorough review
Co-authored-by: Peter Argue <[email protected]>
Co-authored-by: Peter Argue <[email protected]>
Co-authored-by: Peter Argue <[email protected]>
Co-authored-by: Peter Argue <[email protected]>
…ation of GetExecutionDataByBlockID
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly small comments. the main 2 were about error handling and bootstrapping. otherwise this looks good
engine/access/state_stream/backend/backend_executiondata_test.go
Outdated
Show resolved
Hide resolved
engine/access/state_stream/backend/backend_executiondata_test.go
Outdated
Show resolved
Hide resolved
engine/access/state_stream/backend/backend_executiondata_test.go
Outdated
Show resolved
Hide resolved
… before creating NewSnapshotMock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I left a few minor comments.
module/executiondatasync/optimistic_sync/block_execution_data_reader.go
Outdated
Show resolved
Hide resolved
engine/access/state_stream/backend/backend_executiondata_test.go
Outdated
Show resolved
Hide resolved
|
@peterargue could you review it today please? |
|
looks good. please address the conflicts, then we can merge |
closes: #7656
Context