Skip to content

Add Version route #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Version route #25

wants to merge 1 commit into from

Conversation

Parikshit85
Copy link
Collaborator

Pull Request

Related to #3

Description

  • Adding URL "/#/version" to check SHA commit Id.

Things to consider -

  • https://{domainName}/#/version - will be providing 2 information regarding the code that the server is running., the first is the latest SHA commit ID (short) and the name of the environment/branch.
  • This would help differentiate between different environments (stating, prod-gcp).

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have assigned the PR to the appropriate reviewer(s) for their feedback.
  • Are all the improvements/development done?

@Parikshit85 Parikshit85 self-assigned this Oct 3, 2023
@Parikshit85 Parikshit85 added enhancement New feature or request phase-0 labels Oct 3, 2023
AmarildoGrembi
AmarildoGrembi approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@AmarildoGrembi AmarildoGrembi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-10-06 at 00 53 43 LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vishalchangrani vishalchangrani Awaiting requested review from vishalchangrani

1 more reviewer

@AmarildoGrembi AmarildoGrembi AmarildoGrembi approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@Parikshit85 Parikshit85

Labels

enhancement New feature or request phase-0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Parikshit85 @AmarildoGrembi