Repository navigation
fix(importer): skip the embed launcher for missing or blank client IDs (0.7.8 backport) - #210
Merged
behnam-oneschema merged 3 commits intoOct 19, 2026
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…se-0.7 dist-tag Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
… backport Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Bundle size report
|
behnam-oneschema
marked this pull request as ready for review
October 19, 2026 19:19
Member
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
behnam-oneschema
deleted the
devin/1792436843-release-0.7-blank-client-id
branch
October 19, 2026 22:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This backports #209 to the new
release/0.7maintenance line as@oneschema/importer0.7.8. It also adds the release plumbing that publishes that line under the npm dist-tagrelease-0.7, solatestnever moves.release/0.7was cut from9eaa44a0b42a8c9fbe8561a83384b554aabf5037(Version Packages (#188)). All four@oneschema/{importer,react,vue,angular}@0.7.7tags point at that commit.Fix, adapted to the 0.7.7 synchronous API (no new public API or enum members)
"OneSchema config error: clientId must be a non-empty string".LaunchErrorcode is used because main'sInvalidClientIdis a new enum member and can't ship in a patch.Maintenance release plumbing (this branch only; main's
release.ymlis untouched).changeset/config.json:baseBranch: "release/0.7".package.json: thereleasescript runschangeset publish --tag release-0.7.release.yml: triggers on push torelease/0.7. The Changesets action getsbranch: release/0.7and title/commitVersion Packages (release/0.7), so the version PR targetsrelease/0.7fromchangeset-release/release/0.7, which can't collide with main'schangeset-release/main. The read-onlyverifyjob, thereleaseenvironment, OIDC trusted publishing, pinned actions, tag checks andverify-published.mjs(which packsname@version, not a dist-tag) are unchanged.How maintenance releases work (also in
CONTRIBUTING.md#maintenance-releases; README updated)release/<major>.<minor>is cut from that line's last release commit.Version Packages (release/0.7). Merging that PR publishes underrelease-0.7.^0.7.xranges resolve to the newest 0.7 patch by semver.@oneschema/react@0.7.1depends on@oneschema/importer@^0.7.0, so it picks up 0.7.8 on a fresh resolve ornpm update.Repo-admin steps (Behnam)
release/0.7to thereleaseenvironment's deployment-branch policy. (API confirms the policies are nowmainandrelease/0.7.)release/0.7. (protect-mainruleset now also includesrefs/heads/release/*; API confirmsrelease/0.7gets deletion, non-fast-forward, linear history, pull request and required status check rules.)release.yml+ environmentreleasewhen it runs fromrelease/0.7. (npm's trusted-publisher settings have no branch field; the first real check is the firstrelease/0.7publish.)Notes
yarn changeset status --verboseplans only@oneschema/importer0.7.8. With this config the linked group does not bump the wrappers. React, Vue and Angular stay at 0.7.7, and their^0.7.7importer range already admits 0.7.8. I didn't add wrapper changesets.latesttag.Testing
yarn build,yarn check(0 errors; one pre-existing ESLint warning infilefeeds-react),yarn test:ci(importer 9/9),yarn check:ranges,yarn check:install,actionlint."", whitespace,undefinedand123(no src, no iframe, exact failure return andlaunchedevent,console.error, no iframe message). They also cover managed-DOM construction with no client ID (nothing appended), the unchanged default URL, encodingclient id/one→client%20id%2Fone, andlaunchSession()returning the same failure.Link to Devin session: https://app.devin.ai/sessions/8e97956405544cdb86cfaa00c37b94ca
Open in Devin Desktop: https://app.devin.ai/desktop/session/8e97956405544cdb86cfaa00c37b94ca?variant=devin
Requested by: @behnam-oneschema