Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/strong-cats-report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@oneschema/importer": patch
"@oneschema/react": patch
"@oneschema/vue": patch
"@oneschema/angular": patch
---

Include the core importer version in initialization messages for server-side SDK telemetry.
3 changes: 2 additions & 1 deletion packages/importer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@
"build": "yarn run clean && rollup -c && node ../../scripts/dual-types.mjs dist/index.d.ts",
"build-test": "parcel build test/index.html",
"test": "parcel serve test/index.html -p 4242 --open",
"test:ci": "true",
"test:ci": "node --test test/importer.test.cjs",
"test:unit": "yarn build && node --test test/importer.test.cjs",
"fix": "eslint './src/**/**.{ts,js}' --fix",
"check": "eslint './src/**/**.{ts,js}' && tsc --noEmit",
"clean": "npx --yes rimraf dist"
Expand Down
2 changes: 2 additions & 0 deletions packages/importer/src/importer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ export class OneSchemaImporterClass extends EventEmitter<OneSchemaEventMap> {

#client = "Importer"
#version = version
#coreVersion = version

#resumeTokenKey = ""
/** @internal */
Expand Down Expand Up @@ -430,6 +431,7 @@ export class OneSchemaImporterClass extends EventEmitter<OneSchemaEventMap> {
JSON.stringify({
version: this.#version,
client: this.#client,
coreVersion: this.#coreVersion,
"@from": `${this.#client}#${this.#version}`,
"@to": IMPORTER_EMBED_MARKER,
...message,
Expand Down
62 changes: 62 additions & 0 deletions packages/importer/test/importer.test.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
const assert = require("node:assert/strict")
const { test } = require("node:test")

const { version } = require("../package.json")
const { OneSchemaImporterClass } = require("../dist/main.js")

function createImporter() {
global.window = {
addEventListener() {},
removeEventListener() {},
}

const messages = []
const iframe = {
contentWindow: {
postMessage(payload, targetOrigin) {
messages.push({ payload, targetOrigin })
},
},
dataset: {},
style: {},
setAttribute() {},
}
const importer = new OneSchemaImporterClass({
baseUrl: "https://embed.test",
clientId: "client-id",
manageDOM: false,
templateKey: "template-key",
userJwt: "user-jwt",
})

importer.setIframe(iframe)

return { iframe, importer, messages }
}

function postInitMessage(importer, iframe, messages) {
importer.launch()
iframe.onload()
importer.close(true)
return messages[0].payload
}

test("posts the core package version on init messages", () => {
const { iframe, importer, messages } = createImporter()

const payload = postInitMessage(importer, iframe, messages)

assert.equal(payload.messageType, "init")
assert.equal(payload.coreVersion, version)
})

test("keeps the core version separate from the wrapper identity", () => {
const { iframe, importer, messages } = createImporter()
importer.setClient("React", "0.7.4")

const payload = postInitMessage(importer, iframe, messages)

assert.equal(payload.version, "0.7.4")
assert.equal(payload.coreVersion, version)
assert.equal(payload["@from"], "React#0.7.4")
})
Loading