Repository navigation
Version Packages - #154
Merged
Merged
Version Packages#154
Conversation
github-actions
Bot
force-pushed
the
changeset-release/main
branch
17 times, most recently
from
August 30, 2026 00:03
9daadaf to
a1dd50a
Compare
github-actions
Bot
force-pushed
the
changeset-release/main
branch
from
August 30, 2026 00:05
a1dd50a to
bb3d3d2
Compare
behnam-oneschema
added a commit
that referenced
this pull request
Aug 30, 2026
…181) ## Summary The changeset landed in #179 still describes an earlier revision of the React fix — "the React component replaces the instance it destroyed" — which was the shape that created a strict-mode update loop and was reworked (in 032b783) before merge. The component now owns the importer in a mount effect and destroys exactly that instance in its cleanup; nothing is replaced from a cleanup. Wording only, in the unreleased changeset, so the 0.7.6 CHANGELOG shipped to customers matches the code. The Version Packages PR (#154) regenerates from this file. ## Test plan - `npx prettier --check .changeset/importer-destroy-and-typed-events.md` — clean. - No code change; the release notes on #154 update when this lands. Link to Devin session: https://app.devin.ai/sessions/0f6a86671bae4388870cb4d122431d2b Open in Devin Desktop: https://app.devin.ai/desktop/session/0f6a86671bae4388870cb4d122431d2b?variant=devin Requested by: @behnam-oneschema Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
github-actions
Bot
force-pushed
the
changeset-release/main
branch
5 times, most recently
from
August 30, 2026 02:17
04aeb9d to
1dfc76f
Compare
behnam-oneschema
added a commit
that referenced
this pull request
Aug 30, 2026
## Summary `changeset version` rewrites the wrapper packages' `@oneschema/importer` range (`^0.7.0` → `^0.7.6`) but never touches `yarn.lock`, so the Version Packages PR arrives with a lockfile that contradicts its own `package.json`s and every CI job dies in `yarn install --immutable`: ``` YN0028: - "@oneschema/importer": "npm:^0.7.0" YN0028: + "@oneschema/importer": "npm:^0.7.6" YN0028: The lockfile would have been modified by this install, which is explicitly forbidden. ``` The release job's version step now regenerates the lockfile before changesets commits: ```diff -version: yarn changeset version +version: yarn version:packages +# "version:packages": "changeset version && yarn install --mode=update-lockfile" ``` `--mode=update-lockfile` only rewrites `yarn.lock` (link step skipped), so the versioning step stays a metadata-only operation. Verified in a scratch worktree: `yarn version:packages` produces exactly the five lockfile lines CI demanded, and `yarn install --immutable` then passes. Merging this makes the next release run rewrite #154 with the lockfile included, which unblocks the 0.7.6 publish. ## Context - Failing run on #154: https://github.com/oneschema/sdk/actions/runs/33287633101 - Version Packages PR: #154 Link to Devin session: https://app.devin.ai/sessions/0f6a86671bae4388870cb4d122431d2b Open in Devin Desktop: https://app.devin.ai/desktop/session/0f6a86671bae4388870cb4d122431d2b?variant=devin Requested by: @behnam-oneschema Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
github-actions
Bot
force-pushed
the
changeset-release/main
branch
from
August 30, 2026 03:22
1dfc76f to
a2adc89
Compare
behnam-oneschema
force-pushed
the
changeset-release/main
branch
from
August 30, 2026 03:35
a2adc89 to
bb8f89c
Compare
behnam-oneschema
enabled auto-merge (squash)
August 30, 2026 03:35
behnam-oneschema
disabled auto-merge
August 30, 2026 03:36
Contributor
Author
Bundle size report
|
behnam-oneschema
enabled auto-merge (squash)
August 30, 2026 03:37
behnam-oneschema
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@oneschema/importer@0.7.6
Patch Changes
e852152: Add
destroy()and fix themessagelistener leak: cleanup removed a differentfunction reference than the one that was added, so a closed importer kept
handling embed messages.
close(true)now delegates todestroy(). A destroyed instance rejectslaunch()withOneSchemaLaunchError.Destroyedrather than reporting a successit cannot deliver, and the React component now creates and destroys its importer
in a mount effect, so a remount (including React strict mode's double effect)
gets a fresh instance and still imports.
Carry the launch failure detail (
message,status,data) from the embed tothe host on the
launchedevent, and always emit the initialization-timeouterror instead of swallowing it when
devModeis true.Type the event surface with
OneSchemaEventMap, exportPicklistOptionandOneSchemaImportResult, and mark the_-prefixed internals as@internal.e852152: Generate the README option, prop and event references from the TypeScript
types, and correct the drift they had accumulated:
clientID(never a realoption) is
clientId,saveSessiondefaults totruerather thanfalse, theerrorpayload is{ message, severity }, and the callbacks and events thatwere missing are now listed.
0041f56: Document that pnpm projects need to install
eventemitter3alongside the SDK, because the importer class extends it in the published type declarations and pnpm does not hoist transitive dependencies.6c39143: Publish dual ESM and CommonJS package entrypoints with explicit export maps.
@oneschema/angular@0.7.6
Patch Changes
710ef89: Document the
@oneschema/importercompatibility policy and the supported Angular versions in the README.3816ab9: Update
@oneschema/importerpeer dependency range to^0.7.0to match the published importer version.e852152: Add
destroy()and fix themessagelistener leak: cleanup removed a differentfunction reference than the one that was added, so a closed importer kept
handling embed messages.
close(true)now delegates todestroy(). A destroyed instance rejectslaunch()withOneSchemaLaunchError.Destroyedrather than reporting a successit cannot deliver, and the React component now creates and destroys its importer
in a mount effect, so a remount (including React strict mode's double effect)
gets a fresh instance and still imports.
Carry the launch failure detail (
message,status,data) from the embed tothe host on the
launchedevent, and always emit the initialization-timeouterror instead of swallowing it when
devModeis true.Type the event surface with
OneSchemaEventMap, exportPicklistOptionandOneSchemaImportResult, and mark the_-prefixed internals as@internal.0041f56: Document that pnpm projects need to install
eventemitter3alongside the SDK, because the importer class extends it in the published type declarations and pnpm does not hoist transitive dependencies.Updated dependencies [e852152]
Updated dependencies [e852152]
Updated dependencies [0041f56]
Updated dependencies [6c39143]
@oneschema/react@0.7.6
Patch Changes
e852152: Add
destroy()and fix themessagelistener leak: cleanup removed a differentfunction reference than the one that was added, so a closed importer kept
handling embed messages.
close(true)now delegates todestroy(). A destroyed instance rejectslaunch()withOneSchemaLaunchError.Destroyedrather than reporting a successit cannot deliver, and the React component now creates and destroys its importer
in a mount effect, so a remount (including React strict mode's double effect)
gets a fresh instance and still imports.
Carry the launch failure detail (
message,status,data) from the embed tothe host on the
launchedevent, and always emit the initialization-timeouterror instead of swallowing it when
devModeis true.Type the event surface with
OneSchemaEventMap, exportPicklistOptionandOneSchemaImportResult, and mark the_-prefixed internals as@internal.e852152: Generate the README option, prop and event references from the TypeScript
types, and correct the drift they had accumulated:
clientID(never a realoption) is
clientId,saveSessiondefaults totruerather thanfalse, theerrorpayload is{ message, severity }, and the callbacks and events thatwere missing are now listed.
0041f56: Document that pnpm projects need to install
eventemitter3alongside the SDK, because the importer class extends it in the published type declarations and pnpm does not hoist transitive dependencies.6c39143: Publish dual ESM and CommonJS package entrypoints with explicit export maps.
Updated dependencies [e852152]
Updated dependencies [e852152]
Updated dependencies [0041f56]
Updated dependencies [6c39143]
@oneschema/vue@0.7.6
Patch Changes
e852152: Add
destroy()and fix themessagelistener leak: cleanup removed a differentfunction reference than the one that was added, so a closed importer kept
handling embed messages.
close(true)now delegates todestroy(). A destroyed instance rejectslaunch()withOneSchemaLaunchError.Destroyedrather than reporting a successit cannot deliver, and the React component now creates and destroys its importer
in a mount effect, so a remount (including React strict mode's double effect)
gets a fresh instance and still imports.
Carry the launch failure detail (
message,status,data) from the embed tothe host on the
launchedevent, and always emit the initialization-timeouterror instead of swallowing it when
devModeis true.Type the event surface with
OneSchemaEventMap, exportPicklistOptionandOneSchemaImportResult, and mark the_-prefixed internals as@internal.0041f56: Document that pnpm projects need to install
eventemitter3alongside the SDK, because the importer class extends it in the published type declarations and pnpm does not hoist transitive dependencies.a68ce85: Stop shipping the ESLint config file in the published package.
6c39143: Publish dual ESM and CommonJS package entrypoints with explicit export maps.
Updated dependencies [e852152]
Updated dependencies [e852152]
Updated dependencies [0041f56]
Updated dependencies [6c39143]