Skip to content

[App] Remove unused Inter font#64

Merged
scazan merged 1 commit intodevfrom
remove-inter
Jul 27, 2025
Merged

[App] Remove unused Inter font#64
scazan merged 1 commit intodevfrom
remove-inter

Conversation

@metonym
Copy link
Contributor

@metonym metonym commented Jul 26, 2025

Per design, the intended sans-serif is Roboto.

This removes Inter from the app. I also searched for uses of "--font-inter" and there were none.

@metonym metonym requested a review from scazan July 26, 2025 21:17
@vercel
Copy link
Contributor

vercel bot commented Jul 26, 2025

@metonym is attempting to deploy a commit to the One Project team on Vercel, but is not a member of this team. To resolve this issue, you can:

  • Make your repository public. Collaboration is free for open source and public repositories.
  • Add @metonym as a member. A Pro subscription is required to access Vercel's collaborative features.
    • If you're the owner of the team, click here and add @metonym as a member.
    • If you're the user who initiated this build request, click here to request access.
    • If you're already a member of the One Project team, make sure that your Vercel account is connected to your GitHub account.

To read more about collaboration on Vercel, click here.

Copy link
Collaborator

@scazan scazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@metonym metonym marked this pull request as ready for review July 27, 2025 03:45
@claude
Copy link

claude bot commented Jul 27, 2025

Claude finished @metonym's task —— View job


PR Review Complete ✅

I've reviewed this PR for code quality, best practices, potential bugs, performance considerations, and security concerns.

Review Checklist:

  • Read and analyze the changed file (apps/app/src/app/layout.tsx)
  • Check code quality and implementation
  • Look for potential bugs or issues
  • Assess performance impact
  • Review for security concerns
  • Provide comprehensive feedback

Review Feedback

Code Quality & Implementation

  • Clean removal: The PR correctly removes Inter font import, configuration, and CSS variable usage from apps/app/src/app/layout.tsx:8,84
  • Consistent changes: All three necessary modifications were made: import removal, font object removal, and className update
  • Proper Next.js font handling: Uses Next.js font optimization correctly with display: 'swap' for performance

Performance Considerations

  • Reduced bundle size: Removing unused Inter font reduces the bundle size and eliminates unnecessary font downloads
  • Font loading optimization: Roboto fonts maintain proper display: 'swap' configuration for optimal loading performance
  • No runtime impact: Changes are build-time optimizations with no negative runtime effects

Security Concerns

  • No security issues: Font removal poses no security risks
  • Safe dependency removal: Only removes unused font import without affecting any security-related functionality

⚠️ Potential Issues Found

1. Storybook Inconsistency (Minor)

  • Location: packages/ui/stories/index.css:2
  • Issue: Storybook CSS still references 'Inter', sans-serif in the font fallback chain
  • Impact: Storybook components may display differently than the main app if Inter font is not available
  • Recommendation: Update the Storybook CSS to use 'Roboto', sans-serif for consistency:
    :root {
      --font-sans: 'Roboto', sans-serif;
    }

Best Practices

  • Design alignment: Changes correctly implement the design specification to use Roboto
  • Verification performed: Author confirmed no --font-inter CSS variable usage exists
  • Minimal scope: Changes are focused and don't affect unrelated functionality

Recommendation

This is a solid, well-executed change that aligns with the design requirements. The only improvement would be updating the Storybook CSS for complete consistency, but this doesn't block the PR.

Approved ✅ - Ready to merge with optional follow-up for Storybook consistency.


@scazan scazan merged commit 90f3759 into dev Jul 27, 2025
3 of 6 checks passed
@scazan scazan deleted the remove-inter branch July 27, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants