Shared RichTextEditorToolbar for focused editor in ProposalEditor#605
Open
valentin0h wants to merge 5 commits intodevfrom
Open
Shared RichTextEditorToolbar for focused editor in ProposalEditor#605valentin0h wants to merge 5 commits intodevfrom
valentin0h wants to merge 5 commits intodevfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
Visual Changes — Proposal EditorBefore (dev)
After (this PR)
|
valentin0h
force-pushed
the
rich-text-edititing
branch
from
575ec97 to
83ef7c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-adds the RichTextEditorToolbar to the proposal editor, shared across multiple CollaborativeTextField instances. A
useFocusedEditorhook usesrequestAnimationFrameto handle the blur/focus race when switching between editors, keeping the sticky toolbar bound to whichever field has focus. Buttons are disabled when no editor is focused, and an E2E test covers formatting, active state, and cross-field persistence.