Skip to content

Move close button to right side of modal header #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nourmalaeb merged 3 commits into from
Feb 13, 2026
Merged

Move close button to right side of modal header #603

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f1f0c0
Move close button to right side of modal header
nourmalaeb Feb 13, 2026
9e56555
Remove focus ring from modal
nourmalaeb Feb 13, 2026
16d05ff
Format
nourmalaeb Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/ui/src/components/Modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const overlayStyles = tv({
});

const modalStyles = tv({
base: 'isolate z-[999999] h-svh max-h-svh w-screen max-w-md overflow-hidden overflow-y-auto rounded-none border bg-white bg-clip-padding backdrop-blur-lg backdrop-brightness-50 backdrop-saturate-50 focus-visible:outline-hidden sm:h-auto sm:max-h-[calc(100svh-2rem)] sm:max-w-[32rem] sm:rounded-md entering:animate-in entering:duration-500 entering:ease-out entering:fade-in exiting:animate-out exiting:duration-500 exiting:ease-in exiting:fade-out',
base: 'isolate z-[999999] h-svh max-h-svh w-screen max-w-md overflow-hidden overflow-y-auto rounded-none border bg-white bg-clip-padding outline-hidden backdrop-blur-lg backdrop-brightness-50 backdrop-saturate-50 sm:h-auto sm:max-h-[calc(100svh-2rem)] sm:max-w-[32rem] sm:rounded-md entering:animate-in entering:duration-500 entering:ease-out entering:fade-in exiting:animate-out exiting:duration-500 exiting:ease-in exiting:fade-out',
});

type ModalContextType = {
Expand Down Expand Up @@ -58,7 +58,7 @@ export const ModalHeader = ({
aria-label="Close modal"
onClick={handleClose}
className={cn(
'absolute left-6 flex h-6 w-6',
'absolute right-6 flex h-6 w-6',
'items-center justify-center',
'rounded-sm hover:bg-neutral-gray1 focus:ring-2 focus:ring-primary-teal focus:ring-offset-2 focus:outline-hidden',
'text-neutral-charcoal',
Expand Down