Budget field: migrate from plain number to { amount, currency } schema#601
Merged
valentin0h merged 13 commits intodevfrom Feb 13, 2026
Merged
Budget field: migrate from plain number to { amount, currency } schema#601valentin0h merged 13 commits intodevfrom
valentin0h merged 13 commits intodevfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
valentin0h
changed the title
valentin0h
force-pushed
the
proposal-template-budget-field
branch
from
32c3afa to
375ad84
Compare
scazan
approved these changes
Feb 13, 2026
Collaborator
scazan
left a comment
scazan
left a comment
There was a problem hiding this comment.
Approving but we should have a test for the legacy process I think if we are updating the schemas
apps/app/src/components/Profile/CreateDecisionProcessModal/schemas/cowop.ts
Outdated
Show resolved
Hide resolved
apps/app/src/components/decisions/ProposalCard/ProposalCardComponents.tsx
Show resolved
Hide resolved
| <CollaborativeBudgetField | ||
| maxAmount={schema.maximum} | ||
| initialValue={(draft[key] as number | null) ?? null} | ||
| initialValue={null} |
Collaborator
There was a problem hiding this comment.
maybe we just make it optional and null by default?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
numberto{ amount: number, currency: string }{ amount, currency: 'USD' }currencyis not used in any meaningful way yet; it is purely presentational.