Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
nourmalaeb
force-pushed
the
process-builder-validations
branch
from
2a4fa83 to
231df3d
Compare
nourmalaeb
changed the base branch from
rubric-tab-toggle
to
update-process-builder-overview-page
nourmalaeb
commented
Feb 13, 2026
scazan
approved these changes
Feb 13, 2026
Collaborator
scazan
left a comment
scazan
left a comment
There was a problem hiding this comment.
Not blocking here but we should lean into react-query for the header I think. Also let's use zod for validation where can as it'll keep it consistent and hopefully less error-prone.
| useProcessBuilderStore.getState().instances[decisionProfileId]; | ||
|
|
||
| // Server data as base, localStorage edits on top | ||
| const merged = { ...serverData, ...existing }; |
Collaborator
There was a problem hiding this comment.
Just curious. We should be sure if we have deeper nested data that this isn't gonna overwrite objects that are partial in the existing var. I haven't looked at whether that is the case but something to check on:
ie: `serverData = { a: { b: 1, c: 2 } }; existing = { a: { b: 5 }}; {...serverData, ...existing} == { a: { b: 5} };
apps/app/src/components/decisions/ProcessBuilder/ProcessBuilderHeader.tsx
Outdated
Show resolved
Hide resolved
apps/app/src/components/decisions/ProcessBuilder/validation/processBuilderValidation.ts
Show resolved
Hide resolved
apps/app/src/app/[locale]/(no-header)/decisions/[slug]/edit/page.tsx
Outdated
Show resolved
Hide resolved
Validation tweaks Validation popover in header
nourmalaeb
force-pushed
the
process-builder-validations
branch
from
992634b to
1c51580
Compare
nourmalaeb
added a commit
that referenced
this pull request
Feb 13, 2026
The "Launch Process" button in the process builder header now sets the process's status to published. There is a confirmation modal. Stacks on #597 ## Demo https://github.com/user-attachments/assets/eb47652c-5d2b-439a-bb3e-f9f0de34e6f5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validates each step in the process builder and stores the result in localstorage. Updates the "X steps remaining" indicator in the header. Stacks on #596.
Demo
Screen.Recording.2026-02-13.at.12.12.11.AM.mov