ci: add MSRV verification for Rust 1.85#26
Open
don-petry wants to merge 1 commit intooneirosoft:mainfrom
Open
Conversation
Add rust-version = "1.85" to Cargo.toml and a dedicated MSRV check job in the CI workflow to ensure we don't accidentally raise the minimum supported Rust version. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR adds an explicit Minimum Supported Rust Version (MSRV) to the project and enforces it in CI to prevent accidental adoption of newer Rust features than intended.
Changes:
- Declare
rust-version = "1.85"inCargo.toml. - Add an
msrvCI job that runscargo check --locked --all-targetsusing Rust 1.85. - Keep the existing
verifyjob unchanged (still runs fmt/check/test on stable).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Cargo.toml |
Declares MSRV (rust-version = "1.85") in the package manifest. |
.github/workflows/ci.yml |
Adds a dedicated MSRV job pinned to Rust 1.85 running cargo check. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Without an explicit MSRV (minimum supported Rust version), contributors can unknowingly use newer language features that break the build for users on older toolchains. Declaring and testing the MSRV in CI catches these regressions before they're merged.
Summary
rust-version = "1.85"toCargo.tomlto declare the minimum supported Rust versionmsrvjob to the CI workflow that runscargo checkwith Rust 1.85Addresses item 4 in #11.
Test plan
msrvjob passes with Rust 1.85verifyjob remains unaffected🤖 Generated with Claude Code