Skip to content

ci: add cargo clippy lint step#22

Open
don-petry wants to merge 1 commit intooneirosoft:mainfrom
don-petry:ci/add-clippy
Open

ci: add cargo clippy lint step#22
don-petry wants to merge 1 commit intooneirosoft:mainfrom
don-petry:ci/add-clippy

Conversation

@don-petry
Copy link
Copy Markdown
Contributor

@don-petry don-petry commented Mar 31, 2026

Why?

Clippy catches common Rust mistakes, performance issues, and style violations that cargo check misses. Running it in CI prevents these from accumulating — a lint-clean codebase is easier to maintain and review.

Summary

  • Add clippy component to the Rust toolchain installation
  • Add a cargo clippy --locked --all-targets -- -D warnings step after cargo check in CI

Addresses item 1 in #11.

Test plan

  • CI passes with the new clippy step
  • Intentionally introduce a clippy warning and verify CI fails

🤖 Generated with Claude Code

Add clippy component to the Rust toolchain and run cargo clippy with
-D warnings after cargo check to catch common lint issues in CI.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings March 31, 2026 02:48
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR strengthens the Rust CI quality gate by installing the Clippy component and running cargo clippy (with warnings treated as errors) as part of the existing verification workflow, aligning with Issue #11’s first item.

Changes:

  • Install the Rust toolchain with both rustfmt and clippy components.
  • Add a cargo clippy --locked --all-targets -- -D warnings step after cargo check in CI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants