Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/multiple choices with columns #105

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feat/multiple choices with columns #105

wants to merge 2 commits into from

Conversation

totegsito
Copy link

Type:

  • CI/CD: helm, docker & CI/CD adjustments.
  • feature: new capabilities.
  • fix: bug, hotfix, etc.
  • refactor: enhancements.
  • style: changes in styles.
  • other: docs, tests.

What's the focus of this PR:

Add a new option for multiple checkboxes that allows to set up the number of numbers that will be rendered.

How to review this PR:

Play with the example updating the name of columns in the multiple checkbox element

Before submitting this PR, I made sure:

  • There is no lint error in the code
  • Build process passes successfully
  • There are some tests

@totegsito totegsito added the enhancement New feature or request label Nov 8, 2021
ardguezsoc
ardguezsoc reviewed Nov 11, 2021
View reviewed changes
Copy link
Contributor

@ardguezsoc ardguezsoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be cool if you could make some unit testing to this feature but LGTM

@totegsito
Copy link
Author

It would be cool if you could make some unit testing to this feature but LGTM

How could we test this? This new feature is just visual, no output is updated here 😬

@ardguezsoc
Copy link
Contributor

LGTM Then 😢 sorry nice job 😄

@ismaelocaramelo
Copy link
Contributor

There is some conflicts @totegsito

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardguezsoc ardguezsoc ardguezsoc left review comments

@Donivanes Donivanes Awaiting requested review from Donivanes

@ismaelocaramelo ismaelocaramelo Awaiting requested review from ismaelocaramelo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@totegsito @ardguezsoc @ismaelocaramelo