Verify if the provider supports the split operation #1465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldorau
force-pushed
the
Verify_if_the_provider_supports_the_split_operation
branch
2 times, most recently
from
c867ef6 to
2e2bf9c
Compare
lukaszstolarczuk
previously approved these changes
Jul 24, 2025
ldorau
force-pushed
the
Verify_if_the_provider_supports_the_split_operation
branch
from
2e2bf9c to
ff27025
Compare
Replace UMF_RESULT_ERROR_UNKNOWN with UMF_RESULT_ERROR_NOT_SUPPORTED in provider_base_t. Signed-off-by: Lukasz Dorau <[email protected]>
Verify in the initialization of the jemalloc pool if a memory provider supports the split() operation, because the jemalloc pool requires that. Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Verify_if_the_provider_supports_the_split_operation
branch
from
ff27025 to
73858f2
Compare
|
@lukaszstolarczuk Rebased to the v1.0.x branch |
|
The compatibility tests passed: https://github.com/oneapi-src/unified-memory-framework/actions/runs/16519647871 |
3 tasks
|
CI tests passed on my fork: https://github.com/ldorau/unified-memory-framework/actions/runs/16519977366 |
bratpiorka
approved these changes
Jul 28, 2025
|
@lukaszstolarczuk please review |
lukaszstolarczuk
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Verify in the initialization of the jemalloc pool
if a memory provider supports the split() operation,
because the jemalloc pool requires that.
Replace UMF_RESULT_ERROR_UNKNOWN with UMF_RESULT_ERROR_NOT_SUPPORTED
in provider_base_t.
Checklist