Skip to content

retrieve numanode object by os index instead of logical index. #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

retrieve numanode object by os index instead of logical index. #1309

merged 1 commit into from
May 12, 2025
+4 −6

Conversation

lplewa
Copy link
Contributor

@lplewa lplewa commented May 9, 2025

physical_id field stores os index, so we should use correct function to get hwloc numanode object.

fixes: #1289

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used
  • All API changes are reflected in docs and def/map files, and are tested

@lplewa lplewa requested a review from a team as a code owner May 9, 2025 15:27
@lplewa lplewa mentioned this pull request May 9, 2025
Open
@bratpiorka
Copy link
Contributor

@lplewa please add tests that would fail without this change and pass with it

@lukaszstolarczuk lukaszstolarczuk added this to the v0.11.x milestone May 12, 2025
@lplewa
retrieve numanode object by os index instead of logical index.
8791801 
physical_id field stores os index, so we should use correct function
to get hwloc numanode object.

fixes: oneapi-src#1289
@lplewa lplewa changed the base branch from main to v0.11.x May 12, 2025 10:53
@lukaszstolarczuk
Copy link
Contributor

@lplewa please add tests that would fail without this change and pass with it

as agreed test will be delivered in a sep. PR

@bratpiorka bratpiorka merged commit 9bc39c9 into oneapi-src:v0.11.x May 12, 2025
83 of 85 checks passed
@lukaszstolarczuk lukaszstolarczuk mentioned this pull request May 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bratpiorka bratpiorka bratpiorka approved these changes

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.x
Development

Successfully merging this pull request may close these issues.

umfMemspaceHighestBandwidthGet does not use HBM on SapphireRapids+HBM
3 participants
@lplewa @bratpiorka @lukaszstolarczuk